-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: system diagnostic monitor message #96
Conversation
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
byte stop | ||
byte autonomous | ||
byte local | ||
byte remote | ||
byte emergency_stop | ||
byte comfortable_stop | ||
byte pull_over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't these be boolean values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed 62c3ddd
uint32 index | ||
bool used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to have a README for this message to explain what these fields mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment ddcc615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is specifically used to express each operation mode, then it might be better to change the name to something like "OperationModeDiagnositics", "OperationModeAvailability", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed 62c3ddd
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mitsudome-r Can you review this for double-check?
Just as a record, LGTM |
* feat: add diagnostic graph Signed-off-by: Takagi, Isamu <[email protected]> * feat: update diagnostic graph Signed-off-by: Takagi, Isamu <[email protected]> * feat: add links Signed-off-by: Takagi, Isamu <[email protected]> * feat: split status and struct Signed-off-by: Takagi, Isamu <[email protected]> * add name Signed-off-by: Takagi, Isamu <[email protected]> * add summary Signed-off-by: Takagi, Isamu <[email protected]> * add link Signed-off-by: Takagi, Isamu <[email protected]> * add stamp Signed-off-by: Takagi, Isamu <[email protected]> * add stamp Signed-off-by: Takagi, Isamu <[email protected]> * rename message Signed-off-by: Takagi, Isamu <[email protected]> * add comment Signed-off-by: Takagi, Isamu <[email protected]> --------- Signed-off-by: Takagi, Isamu <[email protected]>
Related Links
autowarefoundation/autoware.universe#3829 (comment)
Description
Add diagnostic graph message.
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks